Skip to content

west.yml: hal_stm32: update to fix compiling with clang and pin updates #97308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

west.yml: hal_stm32: update to fix compiling with clang and pin updates #97308

merged 1 commit into from
Oct 17, 2025

Conversation

tpambor
Copy link
Contributor

@tpambor tpambor commented Oct 9, 2025 •
edited by erwango
Loading

Update hal_stm32 to include fix for compiling for STM32H5 with clang.

Fixes warning about extraneous parentheses when compiling with clang.

/home/user/west_workspace/modules/hal/stm32/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_rcc_ex.c:3513:26: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
 3513 |         else if ((srcclk == RCC_USART2CLKSOURCE_PLL3Q))
      |                   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/user/west_workspace/modules/hal/stm32/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_rcc_ex.c:3513:26: note: remove extraneous parentheses around the comparison to silence this warning
 3513 |         else if ((srcclk == RCC_USART2CLKSOURCE_PLL3Q))
      |                  ~       ^                           ~
/home/user/west_workspace/modules/hal/stm32/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_rcc_ex.c:3513:26: note: use '=' to turn this equality comparison into an assignment
 3513 |         else if ((srcclk == RCC_USART2CLKSOURCE_PLL3Q))
      |                          ^~
      |                          =

EDIT (@erwango): Also introduces ALE and CLE pins for the FMC peripheral from a distinct HAL PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_stm32 zephyrproject-rtos/hal_stm32@5d27023 zephyrproject-rtos/hal_stm32@55e1597 (main) zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 9, 2025
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code platform: STM32 ST Micro STM32 labels Oct 9, 2025
@tpambor tpambor force-pushed the update-hal-stm32-clang branch 2 times, most recently from 7249c5b to ba49151 Compare October 13, 2025 11:33
@erwango erwango added this to the v4.3.0 milestone Oct 15, 2025
erwango
erwango previously approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to wait #97126 to be merged first

@erwango
Copy link
Member

erwango commented Oct 16, 2025

Please rebase.

@erwango
Copy link
Member

erwango commented Oct 16, 2025

Btw, if you don't mind, it would be nice to take zephyrproject-rtos/hal_stm32#318 as well. Up to you

@erwango erwango mentioned this pull request Oct 16, 2025
Closed
@tpambor
west.yml: hal_stm32: update to fix compiling with clang and pin updates
e946b85 
Update hal_stm32 to include
- fix for compiling for STM32H5 with clang
- ale/cle pin definitions for FMC peripheral

Signed-off-by: Tim Pambor <[email protected]>
@tpambor tpambor force-pushed the update-hal-stm32-clang branch from ba49151 to e946b85 Compare October 17, 2025 06:22
@github-actions github-actions bot removed DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Modified labels Oct 17, 2025
@erwango
Copy link
Member

erwango commented Oct 17, 2025

Thanks!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tpambor tpambor changed the title west.yml: hal_stm32: update to fix compiling with clang west.yml: hal_stm32: update to fix compiling with clang and pin updates Oct 17, 2025
@henrikbrixandersen henrikbrixandersen merged commit 5b5c057 into zephyrproject-rtos:main Oct 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

@gautierg-st gautierg-st gautierg-st approved these changes

@asm5878 asm5878 Awaiting requested review from asm5878

@benothmn-st benothmn-st Awaiting requested review from benothmn-st

@FRASTM FRASTM Awaiting requested review from FRASTM

@HoZHel HoZHel Awaiting requested review from HoZHel

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

Assignees

@erwango erwango

Labels

manifest manifest-hal_stm32 platform: STM32 ST Micro STM32 size: XS A PR changing only a single line of code

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tpambor @erwango @gautierg-st @henrikbrixandersen @zephyrbot